From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
        "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Anirudha Sarangi" <anirudh@xilinx.com>
Subject: RE: [LINUX PATCH] usb: xhci: Add toggle cycle bit for the last seg
 trb when cached ring is used
Thread-Topic: [LINUX PATCH] usb: xhci: Add toggle cycle bit for the last seg
 trb when cached ring is used
Thread-Index: AQHS2hOxOxRg30POxkKnnHF7NBAC96IPeW0AgACu+YA=
Date: Thu, 1 Jun 2017 16:03:37 +0000
Message-ID: <3802E9A6666DF54886E2B9CBF743BA9827C50205@XAP-PVEXMBX02.xlnx.xilinx.com>
References: <1496238110-4998-1-git-send-email-anuragku@xilinx.com>
 <593014A0.9010509@linux.intel.com>
In-Reply-To: <593014A0.9010509@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2017 16:03:42.4444
 (UTC)
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR02MB337
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v51G4CID013120
Content-Length: 2014
Lines: 50

HI Mathias,

>-----Original Message-----
>From: Mathias Nyman [mailto:mathias.nyman@linux.intel.com]
>Sent: Thursday, June 01, 2017 6:51 PM
>To: Anurag Kumar Vulisha <anuragku@xilinx.com>; mathias.nyman@intel.com;
>gregkh@linuxfoundation.org
>Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Anirudha Sarangi
><anirudh@xilinx.com>; Anurag Kumar Vulisha <anuragku@xilinx.com>
>Subject: Re: [LINUX PATCH] usb: xhci: Add toggle cycle bit for the last seg trb
>when cached ring is used
>
>On 31.05.2017 16:41, Anurag Kumar Vulisha wrote:
>> At present USB 2.0 cameras fail to play when run for 2nd time or greater.
>> This issue occurs only when previous endpoint cached ring is used
>> instead of allocating a new endpoint ring. The root cause of the
>> problem narrows down to the Toggle bit, which is not getting set on
>> the last trb of the cached ring last segment. When the controller
>> fetches the last link trb with no toggle bit set, abnormal behaviour is generated.
>> This patch solves that problem by adding the TOGGLE bit for the last
>> trb of the last segment of the cached ring.
>>
>> Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>
>
>Thanks, nice catch.
>
>I'm thinking about removing the whole endpoint ring caching instead.
>
>We are using more memory by caching the rings instead of freeing them,
>especially as we always try to allocate a new ring and only use the cached ones
>when we fail to allocate a new ring.
>
>Would you be willing to test a patch that removes the ring cache completely with
>your setup?
>

Thanks for reviewing the patch. I completely agree with you. But I think instead of
completely removing the cached ring , can we  modify the code to use cached ring
and try to allocate new ep ring on failure to get cached ring. I have previously sent
the patch for doing this https://lkml.org/lkml/2017/2/22/336
But anyways I am ready to test the changes with my platform. Please correct me
if I am wrong

Thanks,
Anurag Kumar Vulisha
 
>Thanks
>Mathias
>