Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751993AbdFAQE4 (ORCPT ); Thu, 1 Jun 2017 12:04:56 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46691 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbdFAQEx (ORCPT ); Thu, 1 Jun 2017 12:04:53 -0400 Date: Thu, 1 Jun 2017 11:04:33 -0500 From: Reza Arbab To: Michal Hocko Cc: Vlastimil Babka , linux-mm@kvack.org, Andrew Morton , Mel Gorman , Andrea Arcangeli , Jerome Glisse , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML Subject: Re: [RFC PATCH] mm, memory_hotplug: support movable_node for hotplugable nodes References: <20170601122004.32732-1-mhocko@kernel.org> <820164f3-8bef-7761-0695-88db9e0ce7a7@suse.cz> <20170601142227.GF9091@dhcp22.suse.cz> <20170601151935.m5jbfmugocc66qfq@arbab-laptop.localdomain> <20170601153838.GA8088@dhcp22.suse.cz> <20170601154746.wjc56eldgyzr2bpm@arbab-laptop.localdomain> <20170601155204.GB8088@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170601155204.GB8088@dhcp22.suse.cz> Organization: IBM Linux Technology Center User-Agent: NeoMutt/20170428 (1.8.2) X-TM-AS-GCONF: 00 x-cbid: 17060116-0008-0000-0000-000007EBDD82 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007153; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00868737; UDB=6.00431761; IPR=6.00648612; BA=6.00005393; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015670; XFM=3.00000015; UTC=2017-06-01 16:04:39 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17060116-0009-0000-0000-0000426A0274 Message-Id: <20170601160432.yzz7xtk26djki3rx@arbab-laptop.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-01_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706010300 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 24 On Thu, Jun 01, 2017 at 05:52:31PM +0200, Michal Hocko wrote: >On Thu 01-06-17 10:47:46, Reza Arbab wrote: >> On Thu, Jun 01, 2017 at 05:38:38PM +0200, Michal Hocko wrote: >> >On Thu 01-06-17 10:19:36, Reza Arbab wrote: >> >>The x86 SRAT (or the dt, on other platforms) can describe memory as >> >>hotpluggable. See memblock_mark_hotplug(). That's only for memory present at >> >>boot, though. >> > >> >Yes but lose that information after the memblock is gone and numa fully >> >initialized. Or can we reconstruct that somehow? >> >> I'm not sure you'd have to. At boot time, those markings are used to >> determine the initial boundaries of ZONE_MOVABLE. So if you removed these >> memblocks, then readded them, they would still be in ZONE_MOVABLE. > >Yes but that already works like that. I am nore interested in the case >when the node goes away and it is added again. echo online > ... would >result in a non-movable memory and that is the inconsistency I tried to >call out in the changelog My bad. Should have read closer. -- Reza Arbab