Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751332AbdFAUM2 (ORCPT ); Thu, 1 Jun 2017 16:12:28 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:35298 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbdFAUMY (ORCPT ); Thu, 1 Jun 2017 16:12:24 -0400 Subject: Re: [PATCH] tty: add TIOCGPTPEER ioctl To: Aleksa Sarai , Geert Uytterhoeven Cc: Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , "linux-kernel@vger.kernel.org" , alpha , Linux MIPS Mailing List , Parisc List , "linuxppc-dev@lists.ozlabs.org" , Linux-sh list , sparclinux , "linux-xtensa@linux-xtensa.org" , Linux-Arch , Christian Brauner , Valentin Rothberg References: <20170601173803.8698-1-asarai@suse.de> From: Richard Henderson Message-ID: <4e16e83b-8fb7-c9b6-2f06-ee48499a67db@twiddle.net> Date: Thu, 1 Jun 2017 13:12:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 22 On 06/01/2017 01:00 PM, Aleksa Sarai wrote: >>> --- a/arch/alpha/include/uapi/asm/ioctls.h >>> +++ b/arch/alpha/include/uapi/asm/ioctls.h >>> @@ -94,6 +94,7 @@ >>> #define TIOCSRS485 _IOWR('T', 0x2F, struct serial_rs485) >>> #define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of >>> pty-mux device) */ >>> #define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */ >>> +#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */ >> >> Shouldn't the list of definitions be kept sorted, by hex number? >> (everywhere) > > Probably. The reason I put it here is because it logically is very similar to > TIOCGPTN and TIOSPTLCK, but I can move it if the hex order is more important > for maintainence. > Yes please. r~