Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751167AbdFAUOZ (ORCPT ); Thu, 1 Jun 2017 16:14:25 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35885 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbdFAUOY (ORCPT ); Thu, 1 Jun 2017 16:14:24 -0400 Subject: Re: [PATCH net-next v3 5/5] net: dsa: factor skb freeing on xmit To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170601200715.8438-1-vivien.didelot@savoirfairelinux.com> <20170601200715.8438-6-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: <7aa57651-0bdb-730e-2dff-f0b2d2e94532@gmail.com> Date: Thu, 1 Jun 2017 13:14:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170601200715.8438-6-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 20 On 06/01/2017 01:07 PM, Vivien Didelot wrote: > As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"), > the rcv caller frees the original SKB in case or error. > > Be symmetric with that and make the xmit caller do the same. > > At the same time, fix the checkpatch NULL comparison check: > > CHECK: Comparison to NULL could be written "!nskb" > #208: FILE: net/dsa/tag_trailer.c:35: > + if (nskb == NULL) > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli I must have not read the patch correctly the first time, because my objection no longer stands, this looks much cleaner now, thanks! -- Florian