Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbdFAUcK (ORCPT ); Thu, 1 Jun 2017 16:32:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:40976 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751078AbdFAUcJ (ORCPT ); Thu, 1 Jun 2017 16:32:09 -0400 Date: Thu, 1 Jun 2017 22:32:06 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Joe Lawrence cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Miroslav Benes , Petr Mladek Subject: Re: [PATCH 0/3] livepatch: add shadow variable API In-Reply-To: Message-ID: References: <1496341526-19061-1-git-send-email-joe.lawrence@redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 23 On Thu, 1 Jun 2017, Joe Lawrence wrote: > * the intention is that only livepatched code will be calling > klp_shadow_*, so it can assume that the current task is patched Ah, okay, that fully answers my question, thanks. That makes it impossible though to apply the same technique to a single variable twice, without further tweaks (either versioning of the variables, or actually stacking the shadowing itself). Honestly though, I don't think that's going to be a big issue in practice. > Maybe I misunderstood the question... if so, I can update the > documentation file to better describe what's going on. I think you didn't misunderstand it. But it might be beneficial to have a few additional explanatory words in the documentation nevertheless :) Thanks, -- Jiri Kosina SUSE Labs