Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751211AbdFAUnq (ORCPT ); Thu, 1 Jun 2017 16:43:46 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34749 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbdFAUnn (ORCPT ); Thu, 1 Jun 2017 16:43:43 -0400 Date: Thu, 1 Jun 2017 22:43:39 +0200 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Darren Hart Cc: platform-driver-x86@vger.kernel.org, Andy Shevchenko , Andy Lutomirski , Andy Lutomirski , Mario Limonciello , Pali =?utf-8?B?Um9ow6Fy?= , Rafael Wysocki , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 09/16] platform/x86: wmi: Instantiate all devices before adding them Message-ID: <20170601204339.GA1842@kmp-mobile.hq.kempniu.pl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 13 I know I have probably started sounding like a broken record by now, but I still have not seen any response (apart from the typos getting fixed) to my comments on this patch which I posted in January 2016 [1]. None of the issues I found back then are really critical, but I did point out a potential memory leak (granted, an unlikely one), so it might be a good idea to at least take a second look before merging. [1] https://www.spinics.net/lists/platform-driver-x86/msg08201.html -- Best regards, Michał Kępień