Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751221AbdFBEIS convert rfc822-to-8bit (ORCPT ); Fri, 2 Jun 2017 00:08:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:58688 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbdFBEIN (ORCPT ); Fri, 2 Jun 2017 00:08:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,283,1493708400"; d="scan'208";a="1137164114" From: "Dilger, Andreas" To: Tordek CC: Lustre Development List , James Simmons , Linux Kernel Mailing List , "Drokin, Oleg" Subject: Re: [lustre-devel] [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces) Thread-Topic: [lustre-devel] [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces) Thread-Index: AQHSxabx1fKqyjKaD0WQ1Rq693nnt6IQ+6oAgACaEgA= Date: Fri, 2 Jun 2017 04:08:11 +0000 Message-ID: <8FAAC9A9-A33E-40FA-B073-C4E0EAA7725A@intel.com> References: <20170505135129.14757-1-kedrot@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.17.248] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1884 Lines: 55 On Jun 1, 2017, at 14:56, Tordek wrote: > This is fairly minor but it reveals a few hidden warnings, could I get some feedback on it? This is a known problem, but can't immediately be fixed because it affects the interface with userspace tools. The correct solution is to not use struct list_head in the user interface at all, and we are looking into that. In the meantime, feel free to look at the warnings that are now visible after this patch is applied (locally on your system). Thanks, Andreas > > On 5 May 2017 10:53, "Tordek" wrote: > This patch makes a lot of new warnings pop up, because the error is > blocking the rest of the file from being processed. > > On 5 May 2017 at 10:51, Guillermo O. Freschi wrote: >> Signed-off-by: Guillermo O. Freschi >> --- >> drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c >> index da36c55b86d3..f4578200994f 100644 >> --- a/drivers/staging/lustre/lnet/selftest/conrpc.c >> +++ b/drivers/staging/lustre/lnet/selftest/conrpc.c >> @@ -487,7 +487,7 @@ lstcon_rpc_trans_interpreter(struct lstcon_rpc_trans *trans, >> sizeof(struct list_head))) >> return -EFAULT; >> >> - if (tmp.next == head_up) >> + if ((struct list_head __user *)tmp.next == head_up) >> return 0; >> >> next = tmp.next; >> -- >> 2.11.0 >> > _______________________________________________ > lustre-devel mailing list > lustre-devel@lists.lustre.org > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation