MIME-Version: 1.0
In-Reply-To: <abeca9ac-487c-b6dc-1397-4134b0442909@gmail.com>
References: <1495790704-2438-1-git-send-email-anup.patel@broadcom.com>
 <1495790704-2438-5-git-send-email-anup.patel@broadcom.com> <abeca9ac-487c-b6dc-1397-4134b0442909@gmail.com>
From: Anup Patel <anup.patel@broadcom.com>
Date: Fri, 2 Jun 2017 12:02:25 +0530
Message-ID: <CAALAos-YQdr3dwjMDj-upSQMQbE6EHO8aXjjwTdCuTEgM+CR0g@mail.gmail.com>
Subject: Re: [PATCH v5 04/11] arm64: dts: Initial DTS files for Broadcom
 Stingray SOC
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>,
        Oza Pawandeep <oza.oza@broadcom.com>,
        Srinath Mannam <srinath.mannam@broadcom.com>,
        Pramod Kumar <pramod.kumar@broadcom.com>,
        Sandeep Tripathy <sandeep.tripathy@broadcom.com>,
        Device Tree <devicetree@vger.kernel.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        Scott Branden <scott.branden@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 36

On Fri, Jun 2, 2017 at 11:07 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
> On 05/26/2017 02:24 AM, Anup Patel wrote:
>> The Broadcom Stingray SoC is a new member in Broadcom iProc
>> SoC family.
>>
>> This patch adds initial DTS files for Broadcom Stingray SoC
>> and two of its reference boards (bcm958742k and bcm958742t).
>>
>> We have lot of reference boards and large number of devices
>> in Broadcom Stingray SoC so eventually we will have quite
>> a few DTS files for Stingray. To tackle, we have added a
>> separate directory for Stingray DTS files.
>
> So I was going to apply this, but...
>
>
>> +     scr {
>> +             compatible = "simple-bus";
>> +             #address-cells = <1>;
>> +             #size-cells = <1>;
>> +             ranges = <0x0 0x0 0x61000000 0x05000000>;
>
> So you corrected the ranges property here...
>
>> +
>> +             gic: interrupt-controller@63c00000 {
>
> but you kept the original unit address here, which does not match the
> reg property, could you fix that through your entire submission?

Thanks for catching. I quickly update this and send revised patchset.

Regards,
Anup