Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751217AbdFBHMV (ORCPT ); Fri, 2 Jun 2017 03:12:21 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:59932 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbdFBHMU (ORCPT ); Fri, 2 Jun 2017 03:12:20 -0400 Date: Fri, 2 Jun 2017 09:12:08 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Mark the device as active when enabling runtime PM. Message-ID: <20170602091208.2e027cbb@bbrezillon> In-Reply-To: <20170515171615.10168-1-eric@anholt.net> References: <20170515171615.10168-1-eric@anholt.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 28 On Mon, 15 May 2017 10:16:15 -0700 Eric Anholt wrote: > Failing to do so meant that we got a resume() callback on first use of > the device, so we would leak the bin BO that we allocated during > probe. > > Signed-off-by: Eric Anholt > Fixes: 553c942f8b2c ("drm/vc4: Allow using more than 256MB of CMA memory.") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_v3d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c > index e3d5c59dbd4a..825a8462a63b 100644 > --- a/drivers/gpu/drm/vc4/vc4_v3d.c > +++ b/drivers/gpu/drm/vc4/vc4_v3d.c > @@ -403,6 +403,7 @@ static int vc4_v3d_bind(struct device *dev, struct device *master, void *data) > return ret; > } > > + pm_runtime_set_active(dev); > pm_runtime_use_autosuspend(dev); > pm_runtime_set_autosuspend_delay(dev, 40); /* a little over 2 frames. */ > pm_runtime_enable(dev);