Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751182AbdFBKny (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Jun 2017 06:43:54 -0400
Received: from mail-qt0-f179.google.com ([209.85.216.179]:34159 "EHLO
        mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751125AbdFBKnw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Jun 2017 06:43:52 -0400
MIME-Version: 1.0
In-Reply-To: <33942c3893beaca0f82528386fa3b239a6a02f02.1496388893.git.jan.kiszka@siemens.com>
References: <cover.1496388893.git.jan.kiszka@siemens.com> <33942c3893beaca0f82528386fa3b239a6a02f02.1496388893.git.jan.kiszka@siemens.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 2 Jun 2017 13:43:50 +0300
Message-ID: <CAHp75VfaiP_Q59+iQ5ZC8O2gKOeR-gwdJpO5b05MFRdTzagR8A@mail.gmail.com>
Subject: Re: [PATCH v4 5/6] stmmac: pci: Use dmi_system_id table for
 retrieving PHY addresses
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 795
Lines: 35

On Fri, Jun 2, 2017 at 10:34 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr.

> +static const struct stmmac_pci_func_data galileo_stmmac_func_data[] = {
>         {
>                 .func = 6,
>                 .phy_addr = 1,
>         },

> +       { },

Now this is redundant.

> +};

> +static const struct stmmac_pci_dmi_data galileo_stmmac_dmi_data = {
> +       .func = galileo_stmmac_func_data,
> +       .nfuncs = ARRAY_SIZE(galileo_stmmac_func_data),

It will be 2, when is supposed to be 1, see above.

> +};

> +static const struct stmmac_pci_func_data iot2040_stmmac_func_data[] = {

> +       { },
> +};

> +       .nfuncs = ARRAY_SIZE(iot2040_stmmac_func_data),

Ditto.

-- 
With Best Regards,
Andy Shevchenko