Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbdFBLfq (ORCPT ); Fri, 2 Jun 2017 07:35:46 -0400 Received: from mail.ginzinger.com ([31.193.165.229]:36375 "EHLO mail.ginzinger.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbdFBLfo (ORCPT ); Fri, 2 Jun 2017 07:35:44 -0400 From: Henri Roosen To: CC: Henri Roosen , Ohad Ben-Cohen , Bjorn Andersson , open list Subject: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops Date: Fri, 2 Jun 2017 13:35:21 +0200 Message-ID: <1496403321-32234-1-git-send-email-henri.roosen@ginzinger.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.2.1.65] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 24 A device might not have an ops structure registered. This patch fixes a null-prt dereference by checking ops before dereferencing it. Signed-off-by: Henri Roosen --- drivers/rpmsg/rpmsg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 600f5f9..0c48452 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -429,7 +429,7 @@ static int rpmsg_dev_probe(struct device *dev) goto out; } - if (rpdev->ops->announce_create) + if (rpdev->ops && rpdev->ops->announce_create) err = rpdev->ops->announce_create(rpdev); out: return err; -- 2.1.4