Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751240AbdFBO72 (ORCPT ); Fri, 2 Jun 2017 10:59:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbdFBO71 (ORCPT ); Fri, 2 Jun 2017 10:59:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 96E1980477 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=acme@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 96E1980477 Date: Fri, 2 Jun 2017 11:59:22 -0300 From: Arnaldo Carvalho de Melo To: Milian Wolff Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Namhyung Kim , Jiri Olsa , acme@kernel.org Subject: Re: [PATCH] perf report: include partial stacks unwound with libdw Message-ID: <20170602145922.GA7901@redhat.com> References: <20170601210021.20046-1-milian.wolff@kdab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601210021.20046-1-milian.wolff@kdab.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 02 Jun 2017 14:59:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 510 Lines: 16 Em Thu, Jun 01, 2017 at 11:00:21PM +0200, Milian Wolff escreveu: > With this patch applied, the libdw unwinder will produce the same > output as the libunwind unwinder. > +++ b/tools/perf/util/unwind-libdw.c > @@ -224,7 +224,7 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg, > > err = dwfl_getthread_frames(ui->dwfl, thread->tid, frame_callback, ui); > > - if (err && !ui->max_stack) > + if (err && ui->max_stack != max_stack) > err = 0; Simple enough, thanks a lot, applied! - Arnaldo