Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbdFBQaX (ORCPT ); Fri, 2 Jun 2017 12:30:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:32798 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751141AbdFBQaU (ORCPT ); Fri, 2 Jun 2017 12:30:20 -0400 Subject: Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi To: Joshua Clayton , Rob Herring Cc: Alan Tull , Moritz Fischer , Anatolij Gustschin , Bastian Stender , Shawn Guo , Mark Rutland , devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org References: <20170525172911.11467-1-stillcompiling@gmail.com> <20170525172911.11467-5-stillcompiling@gmail.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: Date: Fri, 2 Jun 2017 18:30:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170525172911.11467-5-stillcompiling@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 55 Hi, Am 25.05.2017 um 19:29 schrieb Joshua Clayton: > Add support for Altera V FPGA connected to an spi port Did you mean "Altera Cyclone V"? > to the evi devicetree file > > Signed-off-by: Joshua Clayton > --- > arch/arm/boot/dts/imx6q-evi.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts > index 24fe093a66db..a0cbb2d84803 100644 > --- a/arch/arm/boot/dts/imx6q-evi.dts > +++ b/arch/arm/boot/dts/imx6q-evi.dts > @@ -82,6 +82,15 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1cs>; > status = "okay"; > + > + fpga_spi: cyclonespi@0 { "cyclonespi" does not strike me as the best node name. I am guessing this is a sub-node of a SPI controller node, so no need to repeat "spi", and Cyclone seems more or less implied by "altr,fpga-". Note that the example in the bindings doc uses "evi-fpga-spi". Nodes don't need to be (shouldn't be?) prefixed with the board. Note that bindings examples tend to get copied a lot. Any reason not to just use "fpga@0" in both places for simplicity? > + compatible = "altr,fpga-passive-serial"; > + spi-max-frequency = <20000000>; > + reg = <0>; > + pinctrl-0 = <&pinctrl_fpgaspi>; > + nconfig-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>; > + nstat-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; > + }; > }; > > &ecspi3 { [snip] Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)