Date: Fri, 2 Jun 2017 13:16:30 -0400
From: Sean Paul <seanpaul@chromium.org>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: daniel.vetter@intel.com, jani.nikula@linux.intel.com,
        seanpaul@chromium.org, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: remove writeq/readq function definitions
Message-ID: <20170602171630.rn763baophqv4ekn@art_vandelay>
References: <20170602112510.17544-1-clabbe.montjoie@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170602112510.17544-1-clabbe.montjoie@gmail.com>
User-Agent: NeoMutt/20170306-97-7656f1-dirty (1.8.0)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1194
Lines: 46

On Fri, Jun 02, 2017 at 01:25:10PM +0200, Corentin Labbe wrote:
> Instead of rewriting write/readq, use linux/io-64-nonatomic-lo-hi.h which
> already have them.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Applied to drm-misc-next

Thanks,

Sean

> ---
>  include/drm/drm_os_linux.h | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/include/drm/drm_os_linux.h b/include/drm/drm_os_linux.h
> index 35e1482ba8a1..10122353b744 100644
> --- a/include/drm/drm_os_linux.h
> +++ b/include/drm/drm_os_linux.h
> @@ -6,19 +6,7 @@
>  #include <linux/interrupt.h>	/* For task queue support */
>  #include <linux/sched/signal.h>
>  #include <linux/delay.h>
> -
> -#ifndef readq
> -static inline u64 readq(void __iomem *reg)
> -{
> -	return ((u64) readl(reg)) | (((u64) readl(reg + 4UL)) << 32);
> -}
> -
> -static inline void writeq(u64 val, void __iomem *reg)
> -{
> -	writel(val & 0xffffffff, reg);
> -	writel(val >> 32, reg + 0x4UL);
> -}
> -#endif
> +#include <linux/io-64-nonatomic-lo-hi.h>
>  
>  /** Current process ID */
>  #define DRM_CURRENTPID			task_pid_nr(current)
> -- 
> 2.13.0

-- 
Sean Paul, Software Engineer, Google / Chromium OS