Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751221AbdFBSAd (ORCPT ); Fri, 2 Jun 2017 14:00:33 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38038 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbdFBSAc (ORCPT ); Fri, 2 Jun 2017 14:00:32 -0400 MIME-Version: 1.0 In-Reply-To: References: <1495557626-25285-1-git-send-email-john.stultz@linaro.org> From: John Stultz Date: Fri, 2 Jun 2017 11:00:30 -0700 Message-ID: Subject: Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion To: Xinliang Liu Cc: lkml , Rob Herring , Archit Taneja , Philipp Zabel , Maxime Ripard , Sean Paul , Dave Airlie Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 33 On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu wrote: > On 24 May 2017 at 00:40, John Stultz wrote: >> >> This fixes a regression introduced by ebc944613567 ("drm: >> convert drivers to use drm_of_find_panel_or_bridge") that was >> recently merged, causing HDMI output to not work. >> >> For the kirin driver, the port value should be 1 instead of 0, >> so this oneline patch fixes it and gets graphics working again. >> >> Cc: Rob Herring >> Cc: Archit Taneja >> Cc: Philipp Zabel >> Cc: Maxime Ripard >> Cc: Sean Paul >> Cc: Dave Airlie >> Cc: >> Xinliang Liu >> Fix-suggested-by: Rob Herring >> Signed-off-by: John Stultz > > > Looks good to me. Thanks for the patch. > > Reviewed-by: > Xinliang Liu > Just wanted to check in on this. Is there someone I'm missing from the cc list on this? thanks -john