Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751284AbdFBSOq (ORCPT ); Fri, 2 Jun 2017 14:14:46 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46016 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbdFBSOo (ORCPT ); Fri, 2 Jun 2017 14:14:44 -0400 Date: Fri, 02 Jun 2017 14:14:26 -0400 (EDT) Message-Id: <20170602.141426.713378366601051907.davem@davemloft.net> To: jani.nikula@intel.com Cc: daniel.vetter@ffwll.ch, airlied@gmail.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jani.nikula@linux.intel.com, jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chris@chris-wilson.co.uk, tvrtko.ursulin@intel.com, davidx.m.ertman@intel.com, bruce.w.allan@intel.com Subject: Re: [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails From: David Miller In-Reply-To: <20170531155043.3596-2-jani.nikula@intel.com> References: <20170531.110833.1362264472730468352.davem@davemloft.net> <20170531155043.3596-1-jani.nikula@intel.com> <20170531155043.3596-2-jani.nikula@intel.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 02 Jun 2017 10:32:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 28 From: Jani Nikula Date: Wed, 31 May 2017 18:50:43 +0300 > From: Chris Wilson > > An error during suspend (e100e_pm_suspend), ... > lead to complete failure: ... > The unwind failures stems from commit 2800209994f8 ("e1000e: Refactor PM > flows"), but it may be a later patch that introduced the non-recoverable > behaviour. > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847 > Cc: Tvrtko Ursulin > Cc: Jeff Kirsher > Cc: Dave Ertman > Cc: Bruce Allan > Cc: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org > Signed-off-by: Chris Wilson > [Jani: bikeshed repainted] > Signed-off-by: Jani Nikula Jeff, please make sure this gets submitted to me soon. Thanks.