Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbdFBS3u (ORCPT ); Fri, 2 Jun 2017 14:29:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37412 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbdFBS3s (ORCPT ); Fri, 2 Jun 2017 14:29:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CA73F6025D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 2 Jun 2017 11:29:46 -0700 From: Stephen Boyd To: kgunda@codeaurora.org Cc: Abhijeet Dharmapurikar , Greg Kroah-Hartman , David Collins , Subbaraman Narayanamurthy , Christophe JAILLET , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb Message-ID: <20170602182946.GO20170@codeaurora.org> References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-3-git-send-email-kgunda@codeaurora.org> <20170531004637.GT20170@codeaurora.org> <2bfcb67b77b7bbd1eccd3aeaf11dc75d@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2bfcb67b77b7bbd1eccd3aeaf11dc75d@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 32 On 06/01, kgunda@codeaurora.org wrote: > >>@@ -209,23 +210,24 @@ static void pa_read_data(struct > >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc) > >> * @buf: buffer to write. length must be bc + 1. > >> */ > >> static void > >>-pa_write_data(struct spmi_pmic_arb_dev *dev, const u8 *buf, u32 > >>reg, u8 bc) > >>+pa_write_data(struct spmi_pmic_arb *pa, const u8 *buf, u32 reg, > >>u8 bc) > >> { > >> u32 data = 0; > >>+ > >> memcpy(&data, buf, (bc & 3) + 1); > >>- __raw_writel(data, dev->wr_base + reg); > >>+ pmic_arb_base_write(pa, reg, data); > > > >This is an unrelated change. Not sure what's going on with this > >diff but we most likely want to keep the __raw_writel() here. See > >how renames introduce bugs and why we don't value them? > > > Actually pmic_arb_base_write has the writel_relaxed inside it. > that's why we removed the __raw_writel to use the common function. > Anyways, we drop the renaming patch from this patch series. __raw_writel() is there on purpose because we're reading bytes at a time and the CPU could be big-endian or little-endian. readl_relaxed() would do a byte swap which we don't want. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project