Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbdFBSbd (ORCPT ); Fri, 2 Jun 2017 14:31:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37830 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbdFBSbc (ORCPT ); Fri, 2 Jun 2017 14:31:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9E99360313 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 2 Jun 2017 11:31:30 -0700 From: Stephen Boyd To: kgunda@codeaurora.org Cc: Abhijeet Dharmapurikar , Subbaraman Narayanamurthy , Christophe JAILLET , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups Message-ID: <20170602183130.GP20170@codeaurora.org> References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-5-git-send-email-kgunda@codeaurora.org> <20170531014403.GV20170@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 29 On 06/01, kgunda@codeaurora.org wrote: > On 2017-05-31 07:14, Stephen Boyd wrote: > >On 05/30, Kiran Gunda wrote: > >>diff --git a/drivers/spmi/spmi-pmic-arb.c > >>b/drivers/spmi/spmi-pmic-arb.c > >>index 7201611..6320f1f 100644 > >>--- a/drivers/spmi/spmi-pmic-arb.c > >>+++ b/drivers/spmi/spmi-pmic-arb.c > >>@@ -657,42 +659,6 @@ struct spmi_pmic_arb_irq_spec { > >> unsigned irq:3; > >> }; > >> > >>-static int search_mapping_table(struct spmi_pmic_arb *pa, > >>- struct spmi_pmic_arb_irq_spec *spec, > > > >Perhaps the spec should be removed at some point if this was the > >only place it was passed to. > > > Yes. This is passed only in this function. You want to remove this > structure and pass the slave, per and irq as function parameters? > If so we will do it in the next patch. We don't pass it anywhere though? So I'm just saying have local variables instead of the structure. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project