Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751280AbdFBSxS (ORCPT ); Fri, 2 Jun 2017 14:53:18 -0400 Received: from mail-yw0-f170.google.com ([209.85.161.170]:33359 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbdFBSxQ (ORCPT ); Fri, 2 Jun 2017 14:53:16 -0400 MIME-Version: 1.0 In-Reply-To: References: <1495557626-25285-1-git-send-email-john.stultz@linaro.org> From: Sean Paul Date: Fri, 2 Jun 2017 14:52:47 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion To: John Stultz Cc: Xinliang Liu , lkml , Rob Herring , Archit Taneja , Philipp Zabel , Maxime Ripard , Dave Airlie Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1430 Lines: 45 On Fri, Jun 2, 2017 at 2:00 PM, John Stultz wrote: > On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu wrote: >> On 24 May 2017 at 00:40, John Stultz wrote: >>> >>> This fixes a regression introduced by ebc944613567 ("drm: >>> convert drivers to use drm_of_find_panel_or_bridge") that was >>> recently merged, causing HDMI output to not work. >>> >>> For the kirin driver, the port value should be 1 instead of 0, >>> so this oneline patch fixes it and gets graphics working again. >>> >>> Cc: Rob Herring >>> Cc: Archit Taneja >>> Cc: Philipp Zabel >>> Cc: Maxime Ripard >>> Cc: Sean Paul >>> Cc: Dave Airlie >>> Cc: >>> Xinliang Liu >>> Fix-suggested-by: Rob Herring >>> Signed-off-by: John Stultz >> >> >> Looks good to me. Thanks for the patch. >> >> Reviewed-by: >> Xinliang Liu >> > > Just wanted to check in on this. Is there someone I'm missing from the > cc list on this? > Hi John, Apologies, I just saw this. Slipped through my cracks because it's not posted on dri-devel. The patch looks good. I'll pick it up in drm-misc-fixes if Dave doesn't take it directly into drm-fixes. Sean > thanks > -john