Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751201AbdFBTM5 (ORCPT ); Fri, 2 Jun 2017 15:12:57 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:34576 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbdFBTMz (ORCPT ); Fri, 2 Jun 2017 15:12:55 -0400 MIME-Version: 1.0 In-Reply-To: <3c311c8b-e8a3-0cbe-1c7e-b336c4c0f894@panix.com> References: <20170601210045.8638-1-zackw@panix.com> <20170602071014.GA16118@infradead.org> <3c311c8b-e8a3-0cbe-1c7e-b336c4c0f894@panix.com> From: Linus Torvalds Date: Fri, 2 Jun 2017 12:12:54 -0700 X-Google-Sender-Auth: gLC2cBSvNt8FMH0M98c9SQtCqFQ Message-ID: Subject: Re: [PATCH] uapi/linux/a.out.h: don't use deprecated system-specific predefines. To: Zack Weinberg Cc: Christoph Hellwig , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 655 Lines: 17 On Fri, Jun 2, 2017 at 5:06 AM, Zack Weinberg wrote: > On 06/02/2017 03:10 AM, Christoph Hellwig wrote: >> >> Can we please fix these conditionals so that only those >> relevant to Linux remain? > > I was going for the minimal change since this is dusty-deck code that I > can't practically test, but I have no objection to your more thorough > approach. I don't see anything I would do differently. Yes, I think I'd just prefer to rip out the stale stuff, and remove the "#ifdef linux" entirely. It's not like the kernel wants non-linux headers, and I don't see non-linux users using the kernel headers either. Linus