Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdFBTjc (ORCPT ); Fri, 2 Jun 2017 15:39:32 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35910 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbdFBTja (ORCPT ); Fri, 2 Jun 2017 15:39:30 -0400 From: stillcompiling@gmail.com To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: Joshua Clayton , Rob Herring , Alan Tull , Moritz Fischer , Anatolij Gustschin , Bastian Stender , Shawn Guo , Mark Rutland , devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi Date: Fri, 02 Jun 2017 12:39:27 -0700 Message-ID: <6513199.IxvCuS6eYj@jclayton-pc> User-Agent: KMail/5.2.3 (Linux/4.10.0-21-generic; KDE/5.31.0; x86_64; ; ) In-Reply-To: References: <20170525172911.11467-1-stillcompiling@gmail.com> <20170525172911.11467-5-stillcompiling@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v52JdZVJ013353 Content-Length: 1855 Lines: 65 On Friday, June 2, 2017 6:30:12 PM PDT Andreas F?rber wrote: > Hi, > > Am 25.05.2017 um 19:29 schrieb Joshua Clayton: > > Add support for Altera V FPGA connected to an spi port > > Did you mean "Altera Cyclone V"? I meant to shorten it from Altera Cyclone V to Altera FPGA. Didn't quite make it. Will fix and resubmit today. > > > to the evi devicetree file > > > > Signed-off-by: Joshua Clayton > > --- > > > > arch/arm/boot/dts/imx6q-evi.dts | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx6q-evi.dts > > b/arch/arm/boot/dts/imx6q-evi.dts index 24fe093a66db..a0cbb2d84803 100644 > > --- a/arch/arm/boot/dts/imx6q-evi.dts > > +++ b/arch/arm/boot/dts/imx6q-evi.dts > > @@ -82,6 +82,15 @@ > > > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1cs>; > > status = "okay"; > > > > + > > + fpga_spi: cyclonespi@0 { > > "cyclonespi" does not strike me as the best node name. > > I am guessing this is a sub-node of a SPI controller node, so no need to > repeat "spi", and Cyclone seems more or less implied by "altr,fpga-". True. > > Note that the example in the bindings doc uses "evi-fpga-spi". Nodes > don't need to be (shouldn't be?) prefixed with the board. Note that > bindings examples tend to get copied a lot. > > Any reason not to just use "fpga@0" in both places for simplicity? Sure. fpga: fpga@0 is probably better. I'll change it in both the dts and the binding doc. > > > + compatible = "altr,fpga-passive-serial"; > > + spi-max-frequency = <20000000>; > > + reg = <0>; > > + pinctrl-0 = <&pinctrl_fpgaspi>; > > + nconfig-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>; > > + nstat-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; > > + }; > > > > }; > > > > &ecspi3 { > > [snip] > > Regards, > Andreas -- ~Joshua A Clayton