Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751234AbdFBTya (ORCPT ); Fri, 2 Jun 2017 15:54:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:46308 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750918AbdFBTy2 (ORCPT ); Fri, 2 Jun 2017 15:54:28 -0400 Subject: Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi To: stillcompiling@gmail.com Cc: Rob Herring , Alan Tull , Moritz Fischer , Anatolij Gustschin , Bastian Stender , Shawn Guo , Mark Rutland , devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org References: <20170525172911.11467-1-stillcompiling@gmail.com> <20170525172911.11467-5-stillcompiling@gmail.com> <6513199.IxvCuS6eYj@jclayton-pc> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: Date: Fri, 2 Jun 2017 21:54:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <6513199.IxvCuS6eYj@jclayton-pc> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1619 Lines: 47 Am 02.06.2017 um 21:39 schrieb stillcompiling@gmail.com: > On Friday, June 2, 2017 6:30:12 PM PDT Andreas Färber wrote: >> Am 25.05.2017 um 19:29 schrieb Joshua Clayton: >>> diff --git a/arch/arm/boot/dts/imx6q-evi.dts >>> b/arch/arm/boot/dts/imx6q-evi.dts index 24fe093a66db..a0cbb2d84803 100644 >>> --- a/arch/arm/boot/dts/imx6q-evi.dts >>> +++ b/arch/arm/boot/dts/imx6q-evi.dts >>> @@ -82,6 +82,15 @@ >>> >>> pinctrl-names = "default"; >>> pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1cs>; >>> status = "okay"; >>> >>> + >>> + fpga_spi: cyclonespi@0 { >> >> "cyclonespi" does not strike me as the best node name. >> >> I am guessing this is a sub-node of a SPI controller node, so no need to >> repeat "spi", and Cyclone seems more or less implied by "altr,fpga-". > True. >> >> Note that the example in the bindings doc uses "evi-fpga-spi". Nodes >> don't need to be (shouldn't be?) prefixed with the board. Note that >> bindings examples tend to get copied a lot. >> >> Any reason not to just use "fpga@0" in both places for simplicity? > Sure. fpga: fpga@0 is probably better. Note that I was only commenting on the node name, the latter part. I'm not aware of any rules for the label, so that could remain unchanged or adopt cyclone_spi from the old node name or whatever is unique and syntactically valid. > I'll change it in both the dts and the binding doc. Thanks. Maybe double-check if there's any conventions Xilinx/Lattice DTs are using. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)