Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbdFBUZi (ORCPT ); Fri, 2 Jun 2017 16:25:38 -0400 Received: from fieldses.org ([173.255.197.46]:56552 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbdFBUZh (ORCPT ); Fri, 2 Jun 2017 16:25:37 -0400 Date: Fri, 2 Jun 2017 16:25:36 -0400 From: "J. Bruce Fields" To: Sergei Shtylyov Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Mikulas Patocka , Jason Wang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] virtio_net: lower limit on buffer size Message-ID: <20170602202536.GA24411@fieldses.org> References: <1496361148-4603-1-git-send-email-mst@redhat.com> <3dd90d56-7110-bb9e-0b7f-4c8a8003a57f@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3dd90d56-7110-bb9e-0b7f-4c8a8003a57f@cogentembedded.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 994 Lines: 31 On Fri, Jun 02, 2017 at 12:34:57PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: > > >commit d85b758f72b0 "virtio_net: fix support for small rings" > > Commit d85b758f72b0 ("virtio_net: fix support for small rings") > > >was supposed to increase the buffer size for small rings > >but had an unintentional side effect of decreasing > >it for large rings. This seems to break some setups - > >it's not yet clear why, but increasing buffer size > >back to what it was before helps. > > > >Fixes: d85b758f72b0 "virtio_net: fix support for small rings" > > Fixes: d85b758f72b0 ("virtio_net: fix support for small rings") I may be bikeshedding, but, personally I never do the parens--they're redundant given the quotes, and space is often tight. --b. > > >Reported-by: Mikulas Patocka > >Reported-by: "J. Bruce Fields" > >Signed-off-by: Michael S. Tsirkin > [...] > > MBR, Sergei