Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751339AbdFBU6H (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Jun 2017 16:58:07 -0400
Received: from mail-yb0-f173.google.com ([209.85.213.173]:35687 "EHLO
        mail-yb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751197AbdFBU6E (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Jun 2017 16:58:04 -0400
MIME-Version: 1.0
In-Reply-To: <20170602203128.uxuy5lgzyopvvpkr@ninjato>
References: <1493056826-16776-1-git-send-email-hotran@apm.com>
 <1493056826-16776-3-git-send-email-hotran@apm.com> <20170602203128.uxuy5lgzyopvvpkr@ninjato>
From: Hoan Tran <hotran@apm.com>
Date: Fri, 2 Jun 2017 13:58:03 -0700
Message-ID: <CAFHUOYxYLwWpz__Wu_XYbQeuMDf0uKEcwJJLj2QW7OVM1x8JBA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
        Loc Ho <lho@apm.com>, Keyur Chudgar <kchudgar@apm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 831
Lines: 31

On Fri, Jun 2, 2017 at 1:31 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Mon, Apr 24, 2017 at 11:00:26AM -0700, Hoan Tran wrote:
>> This patch adds ACPI support by using PCC mailbox communication
>> interface.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>
> Please make use checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
> #149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
> +       if (!acpi_disabled) {
> +               mbox_chan_txdone(ctx->mbox_chan, 0);
> +       }
>
> Fixed that and applied to for-next, thanks!

Thanks, Wolfram!

Regards,
Hoan

>
> BTW is there anyone inside apm.com who is willing to take over maintainership
> for this driver? This person needs to review patches thoroughly, yet it usually
> means patches will go in faster.
>
> Regards,
>
>    Wolfram
>