Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387AbdFBVK2 (ORCPT ); Fri, 2 Jun 2017 17:10:28 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34791 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdFBVKZ (ORCPT ); Fri, 2 Jun 2017 17:10:25 -0400 From: stillcompiling@gmail.com To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: stillcompiling@gmail.com, Rob Herring , Alan Tull , Moritz Fischer , Anatolij Gustschin , Bastian Stender , Shawn Guo , Mark Rutland , devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi Date: Fri, 02 Jun 2017 14:10:17 -0700 Message-ID: <14677930.o4g43KgmZP@jclayton-pc> User-Agent: KMail/5.2.3 (Linux/4.10.0-21-generic; KDE/5.31.0; x86_64; ; ) In-Reply-To: References: <20170525172911.11467-1-stillcompiling@gmail.com> <6513199.IxvCuS6eYj@jclayton-pc> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v52LAbGK029166 Content-Length: 1889 Lines: 56 On Friday, June 2, 2017 9:54:22 PM PDT Andreas F?rber wrote: > Am 02.06.2017 um 21:39 schrieb stillcompiling@gmail.com: > > On Friday, June 2, 2017 6:30:12 PM PDT Andreas F?rber wrote: > >> Am 25.05.2017 um 19:29 schrieb Joshua Clayton: > >>> diff --git a/arch/arm/boot/dts/imx6q-evi.dts > >>> b/arch/arm/boot/dts/imx6q-evi.dts index 24fe093a66db..a0cbb2d84803 > >>> 100644 > >>> --- a/arch/arm/boot/dts/imx6q-evi.dts > >>> +++ b/arch/arm/boot/dts/imx6q-evi.dts > >>> @@ -82,6 +82,15 @@ > >>> > >>> pinctrl-names = "default"; > >>> pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1cs>; > >>> status = "okay"; > >>> > >>> + > >>> + fpga_spi: cyclonespi@0 { > >> > >> "cyclonespi" does not strike me as the best node name. > >> > >> I am guessing this is a sub-node of a SPI controller node, so no need to > >> repeat "spi", and Cyclone seems more or less implied by "altr,fpga-". > > > > True. > > > >> Note that the example in the bindings doc uses "evi-fpga-spi". Nodes > >> don't need to be (shouldn't be?) prefixed with the board. Note that > >> bindings examples tend to get copied a lot. > >> > >> Any reason not to just use "fpga@0" in both places for simplicity? > > > > Sure. fpga: fpga@0 is probably better. > > Note that I was only commenting on the node name, the latter part. > > I'm not aware of any rules for the label, so that could remain unchanged > or adopt cyclone_spi from the old node name or whatever is unique and > syntactically valid. Too late! Patches posted. Oh, well, I'm not changing it back. > > > I'll change it in both the dts and the binding doc. > > Thanks. Maybe double-check if there's any conventions Xilinx/Lattice DTs > are using. > Of the conventions I found, fpga seemed the most "hardware descriptive" for a plain FPGA. The other one several binding doc examples are using is "fpga-mgr". > Cheers, > Andreas -- ~Joshua A Clayton