Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbdFBVXC (ORCPT ); Fri, 2 Jun 2017 17:23:02 -0400 Received: from mout.gmx.net ([212.227.17.20]:58819 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdFBVXB (ORCPT ); Fri, 2 Jun 2017 17:23:01 -0400 From: Jens Rottmann Subject: Re: [PATCH] streamline TLV320AIC23 drivers To: Rob Herring References: <20170428171115.6zc5nhspvkkgevs7@rob-hp-laptop> <0ea2a5f8-8af0-598d-ad49-23501176efbb@yahoo.com> Cc: Mark Rutland , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <641616fb-1903-12e3-831e-4744e3ab6bfa@gmx.de> Date: Fri, 2 Jun 2017 23:22:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <0ea2a5f8-8af0-598d-ad49-23501176efbb@yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:HwehJbGLkVLwGeW3T/kuw4I2XcTcFhXs2jVkx1OvtZJvGnw2iFR uhpb9lnSAZ6I4JfRMCZ6X/uBg+UORuz5R4e1T5CUyWK7cnpJ1gI4HJetW/bsJjLJBl7CVE/ /hJXVDM4Sad0qtT54tJWP+FpCkBf93tvlyj8fzjVHJx2GOz2wq6QU+tYKo80ACLZBsqPPsG 8PHva9nBlmQUsNrpTTbiA== X-UI-Out-Filterresults: notjunk:1;V01:K0:yBjY/6A1EHY=:lyb2786CywAbwAsiZ6EMWq M67c8Jma4U2by0P+pIOGSkX1w+LHn5GAo42temUWqqh+I9XAXTSM1hZp4iw743q22DGaDZryz MhzrvROlSXdkyxggmvGb8QmeAZzT6xBg72om9Yf4dx4Te3dbBjwILynyHn0WFwek5fIpBFoJ5 wMOiiIkPpQtt2nTEb+urVShZPnwMRfuTh9nDeS/lMA0LxhfaGWHX6Nj5x2KYltQLlTC0njl8Y lOtbnOPSMKnm7ZjY8kYAwYx5QPulIS4ucTmmdYGWH/IXerq19I9VOCMNyjt9okN9mFQz7dYLD OaEiVEEw2nfoeZCtLw7xGRnQ9HS22089gBtVcpdm64PYzT0WbkWK70NOe3Ly+NAHnFyVFhXd6 Pstgdz4e9MRNs+IWBT/BeaznBlxA8fV3CsNMsobsTyH7NtEyXE94PWV99YUT5kcJSLsbvXv+4 OQBsJMf5r0P5zhv+LuGLnS7TU0vSGh2RHQKLCvJnsM7k/2H6MYsMKtZVqteaRhyLxYPXKr5WI GNJdRotogMyPvw2NpksW/u8SJXi+yCnYa7aYoBdKy9X3/+CQyKutdKXpcMhEMcUEuJEIQeOgn 5mrCYc0Nv6MsfYwifCDVLfBoA8HMEZ0ok9JF7UnYorB8SBEDTur5ZZTdqKYuBH8yCYzhUl+Wc fxS77MN2is9fIys5EGdHjMPF7kT9NxqfrXOo+gEnFPhXLGNqQ18DirO3P3eGRyMGuGM6fSjQX 1+GkEbI2Hl+tf5uPCuwR5whxNkaeKHuIuypunVVLzx0eXmJyUTwySib7+w2etfcESmwuO79kh fn+MyTp Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2898 Lines: 66 Hi Rob, repeatedly got no response. Assuming all my mails got blocked, so moved to yet another account. Hope I'll get through this time. Regards, Jens -------- Original Message -------- Subject: Re: [PATCH] streamline TLV320AIC23 drivers Date: Sat, 6 May 2017 00:39:20 +0200 From: Jens Rottmann To: Rob Herring CC: Mark Rutland, Jaroslav Kysela, Takashi Iwai, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood, Mark Brown Hi Rob, sorry for the delay. > On Fri, Apr 21, 2017 at 09:22:02PM +0200, Jens Rottmann wrote: >> - Remove Eukrea naming, i.MX is from Freescale, TLV320AIC23 is from TI, >> driver was written by Eukrea, but it's DT capable, so it's not exclusive: >> - Kconfig option title >> - 'model' option >> - driver 'compatible' string >> [...] >> CONFIG variable and files have not been renamed, though, so no need to >> change old defconfigs. On 04/28/2017 19:11, Rob Herring answered: > Perhaps change the filename. [...] I wanted to avoid the churn, but ok. In that case: Do you want me to change all indentifiers inside driver, too? eukrea_tlv320_probe() --> imx_tlv320aic23_probe() Do you want me to also rename the CONFIG var? CONFIG_SND_SOC_EUKREA_TLV320 --> CONFIG_SND_SOC_IMX_TLV320 I'd adapt in-tree defconfigs, but would unavoidably break out-of-tree defconfigs... >> - - fsl,mux-int-port : The internal port of the i.MX audio muxer (AUDMUX). >> + - mux-int-port : The internal port of the i.MX audio muxer (AUDMUX). >> + - fsl,mux-int-port : Dito, deprecated. >> - - fsl,mux-ext-port : The external port of the i.MX audio muxer. >> + - mux-ext-port : The external port of the i.MX audio muxer. >> + - fsl,mux-ext-port : Dito, deprecated. > Is this used elsewhere? This is FSL specific, so you should keep the > prefix. .../sound/soc/fsl$ egrep 'property.*mux-(int|ext)-port' * eukrea-tlv320.c: ret = of_property_read_u32(np, "fsl,mux-int-port", &int_port); eukrea-tlv320.c: ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port); fsl-asoc-card.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); fsl-asoc-card.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-es8328.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-es8328.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-sgtl5000.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-sgtl5000.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-wm8962.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-wm8962.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); All drivers use mux-int|ext-port without prefix, tlv320 is the only odd driver out, that's why I did this streamlining patch in the 1st place. I would rather not have to change all other drivers to match the tlv320 one. Thanks, Jens