Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751389AbdFBVdM (ORCPT ); Fri, 2 Jun 2017 17:33:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34938 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdFBVdL (ORCPT ); Fri, 2 Jun 2017 17:33:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A91C66072C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rkuo@codeaurora.org Date: Fri, 2 Jun 2017 16:33:04 -0500 From: Richard Kuo To: Guenter Roeck Cc: linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Subject: Re: hexagon: Use raw_copy_to_user Message-ID: <20170602213303.GA30438@codeaurora.org> References: <1493783568-9887-1-git-send-email-linux@roeck-us.net> <20170602130353.GA11696@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170602130353.GA11696@roeck-us.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2082 Lines: 60 On Fri, Jun 02, 2017 at 06:03:53AM -0700, Guenter Roeck wrote: > ping .... > > On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote: > > Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced > > __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch > > all callers, resulting in the following build error. > > > > arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon': > > arch/hexagon/mm/uaccess.c:40:3: error: > > implicit declaration of function '__copy_to_user_hexagon' > > > > Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") > > Cc: Al Viro > > Signed-off-by: Guenter Roeck > > Acked-by: Al Viro > > --- > > arch/hexagon/mm/uaccess.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c > > index ec90afdb3ad0..c599eb126c9e 100644 > > --- a/arch/hexagon/mm/uaccess.c > > +++ b/arch/hexagon/mm/uaccess.c > > @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count) > > long uncleared; > > > > while (count > PAGE_SIZE) { > > - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page, > > - PAGE_SIZE); > > + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE); > > if (uncleared) > > return count - (PAGE_SIZE - uncleared); > > count -= PAGE_SIZE; > > dest += PAGE_SIZE; > > } > > if (count) > > - count = __copy_to_user_hexagon(dest, &empty_zero_page, count); > > + count = raw_copy_to_user(dest, &empty_zero_page, count); > > > > return count; > > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Richard Kuo Thanks! -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project