Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751303AbdFBVkW (ORCPT ); Fri, 2 Jun 2017 17:40:22 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:17993 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdFBVkU (ORCPT ); Fri, 2 Jun 2017 17:40:20 -0400 Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops To: Henri Roosen , References: <1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com> CC: Ohad Ben-Cohen , Bjorn Andersson , open list From: Suman Anna Message-ID: <053186d1-f05d-06e0-2fa9-e15bcfa5bb02@ti.com> Date: Fri, 2 Jun 2017 16:40:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 27 On 06/02/2017 06:36 AM, Henri Roosen wrote: > Trivial cleanup: the .ops pointer is assigned twice. This patch removes the > first assignment. > > Signed-off-by: Henri Roosen Acked-by: Suman Anna > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 3c582f2..35b8379 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp, > /* Link the channel to our vrp */ > vch->vrp = vrp; > > - /* Assign callbacks for rpmsg_channel */ > - vch->rpdev.ops = &virtio_rpmsg_ops; > - > /* Assign public information to the rpmsg_device */ > rpdev = &vch->rpdev; > rpdev->src = chinfo->src; >