Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbdFCAjg (ORCPT ); Fri, 2 Jun 2017 20:39:36 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18651 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbdFCAje (ORCPT ); Fri, 2 Jun 2017 20:39:34 -0400 To: "Nicholas A. Bellinger" Cc: target-devel , linux-scsi , lkml , Christoph Hellwig , Mike Christie , Hannes Reinecke , "Martin K. Petersen" , Jens Axboe Subject: Re: [PATCH-v2] target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout From: "Martin K. Petersen" Organization: Oracle Corporation References: <1496300702-21835-1-git-send-email-nab@linux-iscsi.org> Date: Fri, 02 Jun 2017 20:39:15 -0400 In-Reply-To: <1496300702-21835-1-git-send-email-nab@linux-iscsi.org> (Nicholas A. Bellinger's message of "Thu, 1 Jun 2017 07:05:02 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 22 Nicholas, > The people who are actively using iblock_execute_write_same_direct() > are doing so in the context of ESX VAAI BlockZero, together with > EXTENDED_COPY and COMPARE_AND_WRITE primitives. > > In practice though I've not seen any users of IBLOCK WRITE_SAME for > anything other than VAAI BlockZero, so just using > blkdev_issue_zeroout() when available, and falling back to > iblock_execute_write_same() if the WRITE_SAME buffer contains anything > other than zeros should be OK. > > (Hook up max_write_zeroes_sectors to signal LBPRZ feature bit in > target_configure_unmap_from_queue - nab) Looks reasonable. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering