Date: Sat, 3 Jun 2017 09:58:45 +0900
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] regmap: make LZO cache optional
Message-ID: <20170603005845.GB24565@kroah.com>
References: <20170602131537.22180-1-jonas.gorski@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170602131537.22180-1-jonas.gorski@gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 968
Lines: 25

On Fri, Jun 02, 2017 at 03:15:37PM +0200, Jonas Gorski wrote:
> Commit 2cbbb579bcbe3 ("regmap: Add the LZO cache support") added support
> for LZO compression in regcache, but there were never any users added
> afterwards. Since LZO support itself has its own size, it currently is
> rather a deoptimization.
> 
> So make it optional by introducing a symbol that can be selected by
> drivers wanting to make use of it.
> 
> Saves e.g. ~46 kB on MIPS (size of LZO support + regcache LZO code).
> 
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
> I tried using google to find any users (even out-of-tree ones), but at
> best I found a single driver submission that was switched to RBTREE in
> subsequent resubmissions (MFD_SMSC).
> 
> One could maybe also just drop the code because of no users for 5 years,
> but that would be up to the maintainer(s) to decide.

Let's just drop it, if there are no users, it shouldn't be there at all.

thanks,

greg k-h