Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751184AbdFCNA4 (ORCPT ); Sat, 3 Jun 2017 09:00:56 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:33160 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbdFCNAy (ORCPT ); Sat, 3 Jun 2017 09:00:54 -0400 MIME-Version: 1.0 In-Reply-To: <3e58ab749a67cce5c956ef13db8563fb0a8bc190.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com> References: <20170531070225.bymdhhpclidwwtpt@dell> <3e58ab749a67cce5c956ef13db8563fb0a8bc190.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Andy Shevchenko Date: Sat, 3 Jun 2017 16:00:52 +0300 Message-ID: Subject: Re: [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq To: Kuppuswamy Sathyanarayanan Cc: Alexandre Courbot , "Krogerus, Heikki" , Greg Kroah-Hartman , Linus Walleij , "edubezval@gmail.com" , "dvhart@infradead.org" , "Zhang, Rui" , Lee Jones , Andy Shevchenko , "linux-gpio@vger.kernel.org" , "linux-pm@vger.kernel.org" , USB , "linux-kernel@vger.kernel.org" , Platform Driver , Sathyanarayanan Kuppuswamy Natarajan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 49 On Thu, Jun 1, 2017 at 1:37 AM, wrote: > From: Kuppuswamy Sathyanarayanan > > PMIC mfd driver only exports first level irq for thermal device. > But currently we are reading the irqs from the second level irq > chip, So this patch fixes this issue by adding support to use > first level PMIC thermal irq. > Shouldn't be this squashed to patch 2? > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Zhang Rui > --- > drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes since v1: > * None > > Changes since v2: > * Rebased on top of latest release. > > Changes since v3: > * Rebased on top of latest release. > > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c > index 0f19a39..ef6b322 100644 > --- a/drivers/thermal/intel_bxt_pmic_thermal.c > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) > } > > regmap = pmic->regmap; > - regmap_irq_chip = pmic->irq_chip_data_level2; > + regmap_irq_chip = pmic->irq_chip_data; > > pmic_irq_count = 0; > while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) { > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko