Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbdFCNEF (ORCPT ); Sat, 3 Jun 2017 09:04:05 -0400 Received: from mail.windriver.com ([147.11.1.11]:51734 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbdFCNEE (ORCPT ); Sat, 3 Jun 2017 09:04:04 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker Subject: [PATCH 0/4] mfd: make da90xx drivers explicitly non-modular Date: Sat, 3 Jun 2017 09:03:47 -0400 Message-ID: <20170603130351.13913-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1945 Lines: 40 At the risk of repeating the same boiler plate, in this cleanup we continue to make driver code consistent with the Makefiles/Kconfigs that control them. This means not using modular functions/macros for drivers that can never be built as a module. Some of the main downfalls this leads to are: (1) it is easy to accidentally write unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else, thus adding to CPP overhead. (4) it gets copied/replicated into other drivers and thus spreads. As always, the option exists for someone with the hardware and the desire to extend the functionality to make any given driver tristate. But given the number of these tree wide and the fact that I can't test that new extended functionality in all cases, I just make the code consistent with existing Kconfig/Makefile settings that currently restrict them to "bool". Build tested on linux-next for arm, arm64 and x86-64 to ensure no typos or similar issues crept in. The diffstat summary speaks for itself. Paul Gortmaker (4): mfd: da903x: Make it explicitly non-modular mfd: da9052-*: Make it explicitly non-modular mfd: da9055-core: make it explicitly non-modular mfd: da9055-i2c: Make it explicitly non-modular drivers/mfd/da903x.c | 26 +++----------------------- drivers/mfd/da9052-core.c | 11 ----------- drivers/mfd/da9052-i2c.c | 22 ++-------------------- drivers/mfd/da9052-irq.c | 1 - drivers/mfd/da9052-spi.c | 22 ++-------------------- drivers/mfd/da9055-core.c | 13 ++----------- drivers/mfd/da9055-i2c.c | 24 ++---------------------- include/linux/mfd/da9052/da9052.h | 1 - 8 files changed, 11 insertions(+), 109 deletions(-) -- 2.11.0