Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbdFCNEO (ORCPT ); Sat, 3 Jun 2017 09:04:14 -0400 Received: from mail.windriver.com ([147.11.1.11]:51762 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbdFCNEM (ORCPT ); Sat, 3 Jun 2017 09:04:12 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Support Opensource , Lee Jones Subject: [PATCH 3/4] mfd: da9055-core: make it explicitly non-modular Date: Sat, 3 Jun 2017 09:03:50 -0400 Message-ID: <20170603130351.13913-4-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170603130351.13913-1-paul.gortmaker@windriver.com> References: <20170603130351.13913-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1743 Lines: 56 The Kconfig currently controlling compilation of this code is: drivers/mfd/Kconfig:config MFD_DA9055 drivers/mfd/Kconfig: bool "Dialog Semiconductor DA9055 PMIC Support" ...meaning that it is never being built as a module. Remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. The exit function deleted here wasn't even registered with module_exit, so it truly was dead code. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. We replace module.h with init.h and export.h ; the latter since the file does export some symbols Cc: Support Opensource Cc: Lee Jones Signed-off-by: Paul Gortmaker --- drivers/mfd/da9055-core.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c index 177e65a12c12..b55f13061547 100644 --- a/drivers/mfd/da9055-core.c +++ b/drivers/mfd/da9055-core.c @@ -11,7 +11,8 @@ * option) any later version. */ -#include +#include +#include #include #include #include @@ -416,13 +417,3 @@ int da9055_device_init(struct da9055 *da9055) mfd_remove_devices(da9055->dev); return ret; } - -void da9055_device_exit(struct da9055 *da9055) -{ - regmap_del_irq_chip(da9055->chip_irq, da9055->irq_data); - mfd_remove_devices(da9055->dev); -} - -MODULE_DESCRIPTION("Core support for the DA9055 PMIC"); -MODULE_LICENSE("GPL"); -MODULE_AUTHOR("David Dajun Chen "); -- 2.11.0