Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbdFCOMv (ORCPT ); Sat, 3 Jun 2017 10:12:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54202 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdFCOMt (ORCPT ); Sat, 3 Jun 2017 10:12:49 -0400 Date: Sat, 3 Jun 2017 18:50:30 +0900 From: Greg KH To: Arvind Yadav Cc: nicolas.ferre@microchip.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] misc: atmel-ssc: Handle return value of clk_prepare_enable and clk_prepare Message-ID: <20170603095030.GA7439@kroah.com> References: <3a6a9ccd68fe298ab33009eaaace85c5af73e1ea.1496381884.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a6a9ccd68fe298ab33009eaaace85c5af73e1ea.1496381884.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 404 Lines: 12 On Fri, Jun 02, 2017 at 11:09:02AM +0530, Arvind Yadav wrote: > clk_prepare_enable() and clk_prepare() can fail here and > we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/misc/atmel-ssc.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) What changed from v1? Always put that information below the --- line. v3 please?