Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751182AbdFCPPQ (ORCPT ); Sat, 3 Jun 2017 11:15:16 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33218 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbdFCPPO (ORCPT ); Sat, 3 Jun 2017 11:15:14 -0400 Date: Sat, 3 Jun 2017 18:15:10 +0300 From: Vladimir Davydov To: Yu Zhao Cc: Johannes Weiner , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: refactor mem_cgroup_resize_limit() Message-ID: <20170603151510.GB15130@esperanza> References: <20170601230212.30578-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601230212.30578-1-yuzhao@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 490 Lines: 13 On Thu, Jun 01, 2017 at 04:02:12PM -0700, Yu Zhao wrote: > mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() have > identical logics. Refactor code so we don't need to keep two pieces > of code that does same thing. > > Signed-off-by: Yu Zhao > --- > mm/memcontrol.c | 71 +++++++++------------------------------------------------ > 1 file changed, 11 insertions(+), 60 deletions(-) Makes sense to me. Acked-by: Vladimir Davydov