Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751181AbdFCPnA (ORCPT ); Sat, 3 Jun 2017 11:43:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33498 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbdFCPm7 (ORCPT ); Sat, 3 Jun 2017 11:42:59 -0400 Date: Sun, 4 Jun 2017 00:42:52 +0900 From: Greg Kroah-Hartman To: Adam Borowski Cc: Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user Message-ID: <20170603154252.GA5123@kroah.com> References: <20170603073255.zgpfmdp2pqusz4qw@angband.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170603073255.zgpfmdp2pqusz4qw@angband.pl> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 17 On Sat, Jun 03, 2017 at 09:32:55AM +0200, Adam Borowski wrote: > Hi! > In a recent discussion, Linus and Al Viro said quite a bit of expletives > about __put_user() and __get_user(), that it's a bad interface that's > almost always the wrong thing to use: > https://marc.info/?l=linux-kernel&m=149463725626316&w=2 > https://marc.info/?l=linux-kernel&m=149465866929092&w=2 > > Here's a few patches applying the lessons from that discussion to vt. > None of the uses is performance-critical, but at least we get a nice bit > of code simplification. And, it's a start of manual review + conversion > that Al Viro wants. Ah, nice work, at first glance these all look good to me. I'll queue them up on Monday. greg k-h