Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236AbdFCRjO (ORCPT ); Sat, 3 Jun 2017 13:39:14 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35517 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdFCRjL (ORCPT ); Sat, 3 Jun 2017 13:39:11 -0400 Date: Sat, 3 Jun 2017 20:39:06 +0300 From: Vladimir Davydov To: Johannes Weiner Cc: Josef Bacik , Michal Hocko , Andrew Morton , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 3/6] mm: memcontrol: use the node-native slab memory counters Message-ID: <20170603173906.GC15130@esperanza> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-4-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530181724.27197-4-hannes@cmpxchg.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 17 On Tue, May 30, 2017 at 02:17:21PM -0400, Johannes Weiner wrote: > Now that the slab counters are moved from the zone to the node level > we can drop the private memcg node stats and use the official ones. > > Signed-off-by: Johannes Weiner > --- > include/linux/memcontrol.h | 2 -- > mm/memcontrol.c | 8 ++++---- > mm/slab.h | 4 ++-- > 3 files changed, 6 insertions(+), 8 deletions(-) Not sure if moving slab stats from zone to node is such a good idea, because they may be useful for identifying the reason of OOM, especially on 32 bit hosts, but provided the previous patch is accepted, this one looks good to me. Acked-by: Vladimir Davydov