Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbdFCRxO (ORCPT ); Sat, 3 Jun 2017 13:53:14 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:34095 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbdFCRxL (ORCPT ); Sat, 3 Jun 2017 13:53:11 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170531070225.bymdhhpclidwwtpt@dell> <3e58ab749a67cce5c956ef13db8563fb0a8bc190.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Sathyanarayanan Kuppuswamy Natarajan Date: Sat, 3 Jun 2017 10:53:09 -0700 Message-ID: Subject: Re: [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq To: Andy Shevchenko Cc: Kuppuswamy Sathyanarayanan , Alexandre Courbot , "Krogerus, Heikki" , Greg Kroah-Hartman , Linus Walleij , "edubezval@gmail.com" , "dvhart@infradead.org" , "Zhang, Rui" , Lee Jones , Andy Shevchenko , "linux-gpio@vger.kernel.org" , "linux-pm@vger.kernel.org" , USB , "linux-kernel@vger.kernel.org" , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1440 Lines: 51 Hi, On Sat, Jun 3, 2017 at 10:32 AM, Andy Shevchenko wrote: > On Sat, Jun 3, 2017 at 8:28 PM, Sathyanarayanan Kuppuswamy Natarajan > wrote: >> Hi, >> >> On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko >> wrote: >>> On Thu, Jun 1, 2017 at 1:37 AM, >>> wrote: >>>> From: Kuppuswamy Sathyanarayanan >>>> >>>> PMIC mfd driver only exports first level irq for thermal device. >>>> But currently we are reading the irqs from the second level irq >>>> chip, So this patch fixes this issue by adding support to use >>>> first level PMIC thermal irq. >>>> >>> >>> Shouldn't be this squashed to patch 2? >> >> There is no compilation dependency between patch 2 and 3. But they are >> functionally dependent. >> >> Should we squash functionally dependent patches too ? > > Let's assume we applied patches 1 and 2, does it mean the regression > to the existing behaviour? Yes, Just applying patch 1 & 2 and not apply patch 3 will create regression in thermal driver. Since there is no compilation dependency between patch 2 & 3 and they are from two different domains, I submitted them separately to make it easier for review. > > (For example, device worked improperly in some cases -> stopped > working completely) > > -- > With Best Regards, > Andy Shevchenko -- Sathya