Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751240AbdFCURf (ORCPT ); Sat, 3 Jun 2017 16:17:35 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:35479 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdFCURe (ORCPT ); Sat, 3 Jun 2017 16:17:34 -0400 Subject: Re: [PATCH] virtio_net: lower limit on buffer size To: "J. Bruce Fields" References: <1496361148-4603-1-git-send-email-mst@redhat.com> <3dd90d56-7110-bb9e-0b7f-4c8a8003a57f@cogentembedded.com> <20170602202536.GA24411@fieldses.org> Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Mikulas Patocka , Jason Wang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Sat, 3 Jun 2017 23:17:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170602202536.GA24411@fieldses.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 22 On 06/02/2017 11:25 PM, J. Bruce Fields wrote: >>> commit d85b758f72b0 "virtio_net: fix support for small rings" >> >> Commit d85b758f72b0 ("virtio_net: fix support for small rings") >> >>> was supposed to increase the buffer size for small rings >>> but had an unintentional side effect of decreasing >>> it for large rings. This seems to break some setups - >>> it's not yet clear why, but increasing buffer size >>> back to what it was before helps. >>> >>> Fixes: d85b758f72b0 "virtio_net: fix support for small rings" >> >> Fixes: d85b758f72b0 ("virtio_net: fix support for small rings") > > I may be bikeshedding, but, personally I never do the parens--they're > redundant given the quotes, and space is often tight. Just see Documetation/process/submitting-patches.rst. MBR, Sergei