Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751308AbdFDO7P (ORCPT ); Sun, 4 Jun 2017 10:59:15 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35437 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbdFDO7L (ORCPT ); Sun, 4 Jun 2017 10:59:11 -0400 Subject: Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures To: Johannes Thumshirn , Christoph Hellwig , Keith Busch Cc: Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170604103649.22130-1-jthumshirn@suse.de> <20170604103649.22130-2-jthumshirn@suse.de> From: Sagi Grimberg Message-ID: Date: Sun, 4 Jun 2017 17:59:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170604103649.22130-2-jthumshirn@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 34 On 04/06/17 13:36, Johannes Thumshirn wrote: > Signed-off-by: Johannes Thumshirn > Reviewed-by: Max Gurtovoy > --- > include/linux/nvme.h | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/include/linux/nvme.h b/include/linux/nvme.h > index b625bacf37ef..afa6ef484e50 100644 > --- a/include/linux/nvme.h > +++ b/include/linux/nvme.h > @@ -288,6 +288,7 @@ enum { > NVME_ID_CNS_NS = 0x00, > NVME_ID_CNS_CTRL = 0x01, > NVME_ID_CNS_NS_ACTIVE_LIST = 0x02, > + NVME_ID_CNS_NS_DESC_LIST = 0x03, > NVME_ID_CNS_NS_PRESENT_LIST = 0x10, > NVME_ID_CNS_NS_PRESENT = 0x11, > NVME_ID_CNS_CTRL_NS_LIST = 0x12, > @@ -314,6 +315,22 @@ enum { > NVME_NS_DPS_PI_TYPE3 = 3, > }; > > +struct nvme_ns_identifier_hdr { > + __u8 nidt; > + __u8 nidl; > + __le16 reserved; > +}; Nit: _hdr is usually associated with a message or alike. Maybe nvme_ns_id_desc is more consistent with the spec language.