Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751366AbdFDP2X (ORCPT ); Sun, 4 Jun 2017 11:28:23 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34718 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdFDP2T (ORCPT ); Sun, 4 Jun 2017 11:28:19 -0400 Subject: Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever To: Christoph Hellwig , Rakesh Pandit Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Jens Axboe , Keith Busch , Andy Lutomirski References: <20170530071610.GA2679@hercules.tuxera.com> <4da7c939-1f54-80e5-48fc-06e58e14f018@grimberg.me> <20170530142346.GA39428@dhcp-216.srv.tuxera.com> <20170601114338.GA24855@lst.de> From: Sagi Grimberg Message-ID: Date: Sun, 4 Jun 2017 18:28:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170601114338.GA24855@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 446 Lines: 11 > I think we need the NVME_CTRL_SCHED_RESET state. In fact I'm pretty > sure some time in the past I already had it in a local tree as a > generalization of rdma and loop already use NVME_CTRL_RESETTING > (they set it before queueing the reset work). I don't remember having it, but I might be wrong... Can you explain again why you think we need it? Sorry for being difficult, but I'm not exactly sure why it makes things better or simpler.