Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751364AbdFDRuP (ORCPT ); Sun, 4 Jun 2017 13:50:15 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:35386 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdFDRuJ (ORCPT ); Sun, 4 Jun 2017 13:50:09 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Ilia Mirkin Date: Sun, 4 Jun 2017 13:50:08 -0400 X-Google-Sender-Auth: V9Sv-8-u4oy_9vNZ03R2x2ZB-U0 Message-ID: Subject: Re: Weird green patterns on video To: Alexandre-Xavier L-L Cc: "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 32 On Sun, Jun 4, 2017 at 1:05 PM, Alexandre-Xavier L-L wrote: > Hello, > > Someone sent me a picture of a device that he tried to add support for > in V4L2. The device causes a kind of diagonal pattern made of green > lines on his image. I wonder what could be causing this. Has anyone > seen this before? > > The device is a the first ever model of Ion Video 2 PC that uses a TM6010 chip. > > What he got: https://sebbro.nl/ION_Video2PC-TM6010_BOARD_GENERIC.png > > Expected result (captured from another device): > https://sebbro.nl/VCR-reference.png > > The support for the device was added by adding > { USB_DEVICE(0x15e4, 0x0140), .driver_info = TM6010_BOARD_GENERIC }, > to tm6000-cards.c. > > Thanks in advance for any clues. > Alexandre-Xavier YUV zero = RGB greenish, as you see there. From the looks of it, the pitch on the buffer is wrong, and you're showing the parts of the buffer that are left zeroed as if they were part of the visible region. (Pitch = how many bytes between lines, which is not necessarily the visible width of the buffer, as it can be rounded up to various values for various reasons.) Hope this helps, -ilia