Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751274AbdFDSPM (ORCPT ); Sun, 4 Jun 2017 14:15:12 -0400 Received: from mail-qt0-f175.google.com ([209.85.216.175]:33657 "EHLO mail-qt0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbdFDSPF (ORCPT ); Sun, 4 Jun 2017 14:15:05 -0400 MIME-Version: 1.0 In-Reply-To: <20170604150659.GH3454@lahna.fi.intel.com> References: <20170602140524.23367-1-mika.westerberg@linux.intel.com> <20170602140524.23367-7-mika.westerberg@linux.intel.com> <20170604135229.GB7207@wunner.de> <20170604150002.GG3454@lahna.fi.intel.com> <20170604150659.GH3454@lahna.fi.intel.com> From: Andy Shevchenko Date: Sun, 4 Jun 2017 21:15:03 +0300 Message-ID: Subject: Re: [PATCH v3 06/27] thunderbolt: Rework capability handling To: Mika Westerberg Cc: Lukas Wunner , Greg Kroah-Hartman , Andreas Noever , Michael Jamet , Yehezkel Bernat , Amir Levy , Andy Lutomirski , Mario Limonciello , Jared.Dominguez@dell.com, Andy Shevchenko , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 30 On Sun, Jun 4, 2017 at 6:06 PM, Mika Westerberg wrote: > On Sun, Jun 04, 2017 at 06:00:02PM +0300, Mika Westerberg wrote: >> On Sun, Jun 04, 2017 at 03:52:29PM +0200, Lukas Wunner wrote: >> > On Fri, Jun 02, 2017 at 05:05:03PM +0300, Mika Westerberg wrote: >> > > Organization of the capabilities in switches and ports is not so random >> > > after all. Rework the capability handling functionality so that it >> > > follows how capabilities are organized and provide two new functions >> > > (tb_switch_find_vsec_cap() and tb_port_find_cap()) which can be used to >> > ^^^^^^^^ >> > >> > I assume VSEC is the same acronym as in the PCIe spec, so this naming >> > scheme results in "vendor specific extended capability capability", >> > which is maybe a bit odd. >> >> AFAIK it comes from Vendor SpEcifiC but I'm not 100% sure ;-) The Alpine >> Ridge datasheet calls it also VSEC capability which is why we chose the >> naming accordingly. > > That said, it could also come from Vendor SpEcific Capability. I can > change it to tb_switch_find_vsec() if that works better. I would folllow PCI existing namings, i.e. _vse_cap() _vse_capability() also possible, but too long to me. -- With Best Regards, Andy Shevchenko