Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbdFDT0F (ORCPT ); Sun, 4 Jun 2017 15:26:05 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36064 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169AbdFDT0A (ORCPT ); Sun, 4 Jun 2017 15:26:00 -0400 Date: Sun, 4 Jun 2017 22:25:54 +0300 From: Vladimir Davydov To: Roman Gushchin Cc: linux-mm@kvack.org, Tejun Heo , Johannes Weiner , Li Zefan , Michal Hocko , Tetsuo Handa , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument Message-ID: <20170604192553.GA19980@esperanza> References: <1496342115-3974-1-git-send-email-guro@fb.com> <1496342115-3974-2-git-send-email-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496342115-3974-2-git-send-email-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 15 On Thu, Jun 01, 2017 at 07:35:09PM +0100, Roman Gushchin wrote: > The select_bad_process() function will be used further > to select a process to kill in the victim cgroup. > This cgroup doesn't necessary match oc->memcg, > which is a cgroup, which limits were caused cgroup-wide OOM > (or NULL in case of global OOM). > > So, refactor select_bad_process() to take a pointer to > a cgroup to iterate over as an argument. IMHO this patch, as well as patches 2-5, doesn't deserve to be submitted separately: none of them make sense as a separate change; worse, patches 4 and 5 introduce user API that doesn't do anything without patch 6. All of the changes are relatively small and singling them out doesn't really facilitate review, so I'd merge them all in patch 6.