Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdFEGdD (ORCPT ); Mon, 5 Jun 2017 02:33:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53502 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbdFEGdB (ORCPT ); Mon, 5 Jun 2017 02:33:01 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 05 Jun 2017 12:03:00 +0530 From: kgunda@codeaurora.org To: Stephen Boyd Cc: Abhijeet Dharmapurikar , Subbaraman Narayanamurthy , Christophe JAILLET , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups In-Reply-To: <20170602183130.GP20170@codeaurora.org> References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-5-git-send-email-kgunda@codeaurora.org> <20170531014403.GV20170@codeaurora.org> <20170602183130.GP20170@codeaurora.org> Message-ID: <45442796e6b8ad41cd63cee761a450b7@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 26 On 2017-06-03 00:01, Stephen Boyd wrote: > On 06/01, kgunda@codeaurora.org wrote: >> On 2017-05-31 07:14, Stephen Boyd wrote: >> >On 05/30, Kiran Gunda wrote: >> >>diff --git a/drivers/spmi/spmi-pmic-arb.c >> >>b/drivers/spmi/spmi-pmic-arb.c >> >>index 7201611..6320f1f 100644 >> >>--- a/drivers/spmi/spmi-pmic-arb.c >> >>+++ b/drivers/spmi/spmi-pmic-arb.c >> >>@@ -657,42 +659,6 @@ struct spmi_pmic_arb_irq_spec { >> >> unsigned irq:3; >> >> }; >> >> >> >>-static int search_mapping_table(struct spmi_pmic_arb *pa, >> >>- struct spmi_pmic_arb_irq_spec *spec, >> > >> >Perhaps the spec should be removed at some point if this was the >> >only place it was passed to. >> > >> Yes. This is passed only in this function. You want to remove this >> structure and pass the slave, per and irq as function parameters? >> If so we will do it in the next patch. > > We don't pass it anywhere though? So I'm just saying have local > variables instead of the structure. Sure. Thanks for the clarification.