Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbdFEHyG (ORCPT ); Mon, 5 Jun 2017 03:54:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34360 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdFEHyD (ORCPT ); Mon, 5 Jun 2017 03:54:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 74A5A60234 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback To: Philipp Zabel , Jose Abreu References: <3d8d449e4d13d2535fa292c75f5fa931de4a4fa8.1495720737.git.joabreu@synopsys.com> <49c4273c-eb14-da5d-f85d-a3a944f8f9cd@codeaurora.org> <1496140141.5485.3.camel@pengutronix.de> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mark Yao , Carlos Palminha , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , David Airlie , Carlo Caione , Kevin Hilman , Heiko Stuebner From: Archit Taneja Message-ID: <17256a1e-f3a5-e6b3-ea77-064e636615dd@codeaurora.org> Date: Mon, 5 Jun 2017 13:23:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1496140141.5485.3.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 45 On 05/30/2017 03:59 PM, Philipp Zabel wrote: > Hi Archit, > > On Tue, 2017-05-30 at 15:54 +0530, Archit Taneja wrote: >> Hi, >> >> On 05/25/2017 07:49 PM, Jose Abreu wrote: >>> Now that we have a callback to check if bridge supports a given mode >>> we can use it in Synopsys Designware HDMI bridge so that we restrict >>> the number of probbed modes to the ones we can actually display. >>> >>> Also, there is no need to use mode_fixup() callback as mode_valid() >>> will handle the mode validation. >>> >>> NOTE: Only compile tested >>> NOTE 2: I also had to change the pdata declaration of mode_valid >>> custom callback so that the passed modes are const. I also changed >>> in the platforms I found. Not even compiled it though. >> >> This compiles fine and has been tested on Meson by Neil. >> >> Since this also touches rockchip/imx drm driver files, can I get an >> OK from the maintainers to pull the changes via drm-misc? > > Of course, > Acked-by: Philipp Zabel Thanks for the Ack. I didn't get an ack from Rockchip, but still going ahead with the push since it's been a while and the change is very minor. Thanks, Archit > > regards > Philipp > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project