Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbdFEIXX (ORCPT ); Mon, 5 Jun 2017 04:23:23 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:54652 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437AbdFEIXV (ORCPT ); Mon, 5 Jun 2017 04:23:21 -0400 From: Xinming Hu To: Colin King , Amitkumar Karwar , Nishant Sarmukadam , "Ganapathi Bhat" , Kalle Valo , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Cathy Luo Subject: Re: [PATCH][-next] mwifiex: make function mwifiex_ret_pkt_aggr_ctrl static Thread-Topic: [PATCH][-next] mwifiex: make function mwifiex_ret_pkt_aggr_ctrl static Thread-Index: AQHS3dT5PQbh/E9Qj0m1lQSddWtxvw== Date: Mon, 5 Jun 2017 08:23:13 +0000 Message-ID: <0edf9f73cf2f49788ef767658cd038d0@SC-EXCH02.marvell.com> References: <20170602085639.29338-1-colin.king@canonical.com> In-Reply-To: <20170602085639.29338-1-colin.king@canonical.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-05_02:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706050155 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v558NSLo025712 Content-Length: 1751 Lines: 52 Hi Colin, > -----Original Message----- > From: Colin King [mailto:colin.king@canonical.com] > Sent: 2017年6月2日 16:57 > To: Amitkumar Karwar; Nishant Sarmukadam; Ganapathi Bhat; Xinming Hu; > Kalle Valo; linux-wireless@vger.kernel.org; netdev@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [EXT] [PATCH][-next] mwifiex: make function > mwifiex_ret_pkt_aggr_ctrl static > > External Email > > ---------------------------------------------------------------------- > From: Colin Ian King > > function mwifiex_ret_pkt_aggr_ctrl can be made static as it does not need to > be in global scope. > > Cleans up sparse warning: "symbol 'mwifiex_ret_pkt_aggr_ctrl' was not > declared. Should it be static?" Yes, it should be static, Thanks, Regards, Simon > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > b/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > index 3348fb3a7514..2945775e83c5 100644 > --- a/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > @@ -1154,8 +1154,8 @@ static int mwifiex_ret_chan_region_cfg(struct > mwifiex_private *priv, > return 0; > } > > -int mwifiex_ret_pkt_aggr_ctrl(struct mwifiex_private *priv, > - struct host_cmd_ds_command *resp) > +static int mwifiex_ret_pkt_aggr_ctrl(struct mwifiex_private *priv, > + struct host_cmd_ds_command *resp) > { > struct host_cmd_ds_pkt_aggr_ctrl *pkt_aggr_ctrl = > &resp->params.pkt_aggr_ctrl; > -- > 2.11.0