Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751417AbdFEJys (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 05:54:48 -0400
Received: from smtp.eu.citrix.com ([185.25.65.24]:17294 "EHLO
        SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751293AbdFEJyr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 05:54:47 -0400
X-IronPort-AV: E=Sophos;i="5.39,300,1493683200"; 
   d="scan'208";a="47211108"
Subject: Re: [PATCH] xen-evtchn: Bind dyn evtchn:qemu-dm interrupt to next
 online VCPU
To: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        <linux-kernel@vger.kernel.org>
CC: <boris.ostrovsky@oracle.com>
References: <1496414988-12878-1-git-send-email-anoob.soman@citrix.com>
 <a75010da-0e62-5153-2dd2-2069a3c5f54f@suse.com>
From: Anoob Soman <anoob.soman@citrix.com>
Message-ID: <3c5989b7-c5b4-6602-5b09-46277860653e@citrix.com>
Date: Mon, 5 Jun 2017 10:54:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <a75010da-0e62-5153-2dd2-2069a3c5f54f@suse.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: FTLPEX02CAS02.citrite.net (10.13.99.123) To
 AMSPEX02CL02.citrite.net (10.69.22.126)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 434
Lines: 22

On 02/06/17 16:10, Juergen Gross wrote:
>
> I'd prefer the to have irq disabled from taking the lock until here.
> This will avoid problems due to preemption and will be faster as it
> avoids one irq on/off cycle. So:
>
> local_irq_disable();
> raw_spin_lock();
> ...
> raw_spin_unlock();
> this_cpu_write();
> xen_rebind_evtchn_to_cpu();
> local_irq_enable();
>
>
> Juergen


Agreed, I will send a V2 with your suggestion.


-Anoob.