Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdFEJ4T (ORCPT ); Mon, 5 Jun 2017 05:56:19 -0400 Received: from mga07.intel.com ([134.134.136.100]:23476 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbdFEJ4R (ORCPT ); Mon, 5 Jun 2017 05:56:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,300,1493708400"; d="scan'208";a="1178386916" Date: Mon, 5 Jun 2017 12:56:13 +0300 From: Heikki Krogerus To: Badhri Jagan Sridharan Cc: Greg Kroah-Hartman , Guenter Roeck , Oliver Neukum , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6] usb: typec: Add a sysfs node to manage port type Message-ID: <20170605095613.GI26659@kuha.fi.intel.com> References: <20170530193953.4310-1-Badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530193953.4310-1-Badhri@google.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 22 Hi, Sorry for the late reply. I was unable to follow my email last week. On Tue, May 30, 2017 at 12:39:53PM -0700, Badhri Jagan Sridharan wrote: > User space applications in some cases have the need to enforce a > specific port type(DFP/UFP/DRP). This change allows userspace to > attempt setting the desired port type. Low level drivers can > however reject the request if the specific port type is not supported. > > Signed-off-by: Badhri Jagan Sridharan > Reviewed-by: Guenter Roeck It looks good to me. In case Greg has not yet picked this: Acked-by: Heikki Krogerus Thanks, -- heikki