Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696AbdFEKHo (ORCPT ); Mon, 5 Jun 2017 06:07:44 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:12015 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdFEKHa (ORCPT ); Mon, 5 Jun 2017 06:07:30 -0400 X-AuditID: b6c32a36-f79446d000002bcd-10-59352d5fba87 Subject: Re: [PATCH] media: platform: s3c-camif: fix arguments position in function call To: "Gustavo A. R. Silva" Cc: Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: <593b0303-7273-758c-cb6e-c6f97f66a4b9@samsung.com> Date: Mon, 05 Jun 2017 12:07:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-version: 1.0 In-reply-to: <20170602034341.GA5349@embeddedgus> Content-type: text/plain; charset="utf-8"; format="flowed" Content-language: en-GB Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsWy7bCmnm68rmmkwYcDBhYrl+xnszg1+RmT xeVdc9gsejZsZbWYcX4fk8WyTX+YHNg81h1U9di0qpPN4/MmOY9TXz+zB7BEcdmkpOZklqUW 6dslcGWsm/uPveAEX8XjxpOsDYwtPF2MnBwSAiYS65dNYoWwxSQu3FvP1sXIxSEksINRYsPR ecwQzmdGiS0btzLCdHz6M5cFrqrl5y12COc+o8TCE1OAHA4OYYEoicWrU0AaRASMJa4938cE UsMssJlR4u7eFrB9bAKGEr1H+8Cm8grYSay/9pwZxGYRUJV4t2I7mC0qECGxaNJEdogaQYkf k++xgMznFDCQuHhMAyTMLGAl8exfKyuELS5x7P5NRghbXmLzmrdgH0gIzGOX2Nh5jxGkV0JA VmLTAWaIZ1wk1nbsh7KFJV4d38IOYUtJNL58yATR288ocWJNMyOEM4NR4k77BCaIKmuJw8cv Qm3mk3j3tYcVYgGvREebEESJh8T5n81QCxwl1ixZBg3fZkaJA7v3MU9gVJiF5LdZSB6aheSh WUgeWsDIsopRLLWgODc9tdiwwEivODG3uDQvXS85P3cTIzjhaJntYFx0zucQowAHoxIPr0Sm SaQQa2JZcWXuIUYJDmYlEd7i60Ah3pTEyqrUovz4otKc1OJDjNIcLErivKLrr0UICaQnlqRm p6YWpBbBZJk4OKUaGAsMKndq748/fTdFzflkZFbSsTXPZJyVEi58sm7mt8gW/184hUP9kk8i jw5Dr45R/rRLrWzmDN7cKdPK9kpt4retvrdt5wSJF4Zem9XCslQSDW411H3KO6l+TqDXd+Zb 9YRbEitSDkbo1lkHLDXf47zB+ehzHvHbH7ZXXtbxU427zR/i+ytKiaU4I9FQi7moOBEAJ7R4 HzQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsVy+t9jAd14XdNIg88T5S1WLtnPZnFq8jMm i8u75rBZ9GzYymox4/w+Jotlm/4wObB5rDuo6rFpVSebx+dNch6nvn5mD2CJcrPJSE1MSS1S SM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvGurn/ 2AtO8FU8bjzJ2sDYwtPFyMkhIWAi8enPXBYIW0ziwr31bF2MXBxCAtsYJd5e+8UO4TxklLg/ /yxjFyMHh7BAlMTi1SkgDSICxhLXnu9jAqlhFtjMKHH6UTsjSEJIoJVR4vEadxCbTcBQovdo H1icV8BOYv2158wgNouAqsS7FdvBbFGBCIld1w+wQtQISvyYfI8FZBengIHExWMaIGFmATOJ Ly8Ps0LY4hLH7t9khLDlJTavecs8gVFwFpLuWUhaZiFpmYWkZQEjyypGrtSC4tz03GKjAsNN jMAI23ZYy38H44+z0YcYBTgYlXh4JTJNIoVYE8uKK3MPMUpwMCuJ8BZfBwrxpiRWVqUW5ccX leakFh9iNAX6aCKzlGhyPjD680riDU0sjUwMzMwMjQyMzZTEeScEfokQEkhPLEnNTk0tSC2C 6WPi4JRqYBQ1Wv5WOGgPo8S+yquJ5dcb/xy9/epmnsShJ3pF1rkidzbN/cih6zd533v7Yrec nQu9FJoctZs/7L6u90TsTeQKc0efBVW9HRwTkhjmT7/9P/lMHN/dtyeUu9JmlnUHNKkecC86 r7nbcOGh7hMXbnJzbZ6m6CB6xPC84u+m+LtCTx/33Uve/lqJpTgj0VCLuag4EQBjTqlRxgIA AA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170605100727epcas1p14aaef207c6f4365909f2f3f054768363 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170602034354epcas1p1bfea44bea994a5cbd8095a8f4da09cd0 X-RootMTR: 20170602034354epcas1p1bfea44bea994a5cbd8095a8f4da09cd0 References: <20170602034341.GA5349@embeddedgus> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 47 On 06/02/2017 05:43 AM, Gustavo A. R. Silva wrote: > Hi Sylwester, > > Here is another patch in case you decide that it is > better to apply this one. Thanks, I applied this patch. In future please put any comments only after the scissors ("---") line, the comments can be then discarded automatically and there will be no need for manually editing the patch before applying. -- Regards, Sylwester > Fix the position of the arguments in function call. > > Addresses-Coverity-ID: 1248800 > Addresses-Coverity-ID: 1269141 > Signed-off-by: Gustavo A. R. Silva > --- ^^^^^ > drivers/media/platform/s3c-camif/camif-capture.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c > index 1b30be72..25c7a7d 100644 > --- a/drivers/media/platform/s3c-camif/camif-capture.c > +++ b/drivers/media/platform/s3c-camif/camif-capture.c > @@ -80,7 +80,7 @@ static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp) > camif_hw_set_test_pattern(camif, camif->test_pattern); > if (variant->has_img_effect) > camif_hw_set_effect(camif, camif->colorfx, > - camif->colorfx_cb, camif->colorfx_cr); > + camif->colorfx_cr, camif->colorfx_cb); > if (variant->ip_revision == S3C6410_CAMIF_IP_REV) > camif_hw_set_input_path(vp); > camif_cfg_video_path(vp); > @@ -364,7 +364,7 @@ irqreturn_t s3c_camif_irq_handler(int irq, void *priv) > camif_hw_set_test_pattern(camif, camif->test_pattern); > if (camif->variant->has_img_effect) > camif_hw_set_effect(camif, camif->colorfx, > - camif->colorfx_cb, camif->colorfx_cr); > + camif->colorfx_cr, camif->colorfx_cb); > vp->state &= ~ST_VP_CONFIG; > } > unlock: